polkadot-js / apps

Basic Polkadot/Substrate UI for interacting with a Polkadot and Substrate node. This is the main user-facing application, allowing access to all features available on Substrate chains.
https://dotapps.io
Apache License 2.0
1.75k stars 1.54k forks source link

Crowdloan in Network > Parachains > then the crowdloan link shows wrong interface #5555

Closed joelamouche closed 3 years ago

joelamouche commented 3 years ago

If you go to Network > Parachains > then the crowdloan link from menu then the + contribute button to get that pop up, you will see this wrong interface: image (3)

But if i got to developer > extrinsic > then the crowdloan - contribute it’ll work image (2)

jacogr commented 3 years ago

It actually expects the full MultiSignature hex encoded. So in this case, since it is ed25519, it will be 0x0298... (extra 02 at the start)

EDIT: Typo above, it is sr25519, so the first byte is 01 - but basically the output of multiSignature.toHex() (double-mistake there: misread and then still got it wrong in order)

joelamouche commented 3 years ago

Thank you! But shouldn't it be the same interface as the extrinsic interface?

jacogr commented 3 years ago

No. In this case since the hex is provided, rather not expect the users to know which type of signature it is as well. So it is treated as an opaque properly-encoded blob from multiSignature.toHex().

joelamouche commented 3 years ago

OKay sounds good

polkadot-js-bot commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.