polkadot-js / apps

Basic Polkadot/Substrate UI for interacting with a Polkadot and Substrate node. This is the main user-facing application, allowing access to all features available on Substrate chains.
https://dotapps.io
Apache License 2.0
1.74k stars 1.53k forks source link

OpenGov delegations. Meaning of "votes" on account gov activity #9498

Open Juanma0x opened 1 year ago

Juanma0x commented 1 year ago

When delegating in OpenGov, once an account is selected (delegator or delegate), some information about the voting/delegation activity of the account is displayed. However, the meaning of the values are not described and do not appear to correspond to any consistent voting activity for the account.

As a simple example, Seun Lanlege, a Technical Felloship member, appears with 1 vote on "Whitelisted Caller" track:

image

However, Seun's activity tells a different history, with 3 votes (all on the "Whitelisted Caller" track)

image

Also, there are tracks with "0 votes" on some accounts (e.g. Oliver). What does it mean? Why are so many votes from Oliver not shown by the UI?

Either if Subscan information is accurate or not, a description for each value should help the delegator to delegate wisely.

jacogr commented 1 year ago

The UI only queries the state - so it is active votes, i.e. those in the state that has not been removed via removeVote (which is generally done after a referendum is completed to free funds)

Subscan on the other had trawls the state and blocks and builds an offline database - so it will display all extrinsics that made vote, including those that are active (still available on a referendum) and those that are not active anymore (where removeVote was called).

Juanma0x commented 1 year ago

Thanks, it clears some doubts I had. Some other questions/suggestions:

Nevertheless, providing more details in the description would help users know who they are delegating to.

And thanks for your time building and answering my questions. I really appreciate it.

michalisFr commented 1 year ago

@jacogr Thanks for replying to @juanweb3.

If I understand correctly, the info shown in that page is fetched directly from convictionVoting.votingFor, which includes votes in ongoing referenda and locks for ended referenda that haven't been removed, correct?

However, there seems to be a discrepancy with tracks 10 and 33, where votes in track 33 (medium spender) are shown in track 10 (staking admin) and vice versa.

Here's a screenshot of my account (GA9psXCW91jbLCn6jySFovNyc7kFsZBtC21YoAT8vNsY2Hc):

Screenshot 2023-06-06 at 6 08 07 PM

If you check its chain state, you'll see what I mean: the 8 votes shown for track 10 are actually for track 33 and vice versa.