polkadot-js / apps

Basic Polkadot/Substrate UI for interacting with a Polkadot and Substrate node. This is the main user-facing application, allowing access to all features available on Substrate chains.
https://dotapps.io
Apache License 2.0
1.75k stars 1.54k forks source link

Parallel Ledger account overwrites Polkadot Ledger account on Polkadot-JS UI #9681

Open Juanma0x opened 1 year ago

Juanma0x commented 1 year ago

To replicate this scenario, follow the steps below:

  1. Install the Polkadot Ledger app with version 23.9420.2.
  2. Install the developer version of the Parallel Ledger app, specifically version 17.189.9.
  3. Add the Polkadot Ledger account to either the Polkadot-JS UI, or use the Polkadot extension.
  4. Next, add the Parallel Ledger account.

The outcome of these steps is as follows:

Desired outcome:

Context: From the issue opened on Zondax/ledger-parallel

[...] I can tell you that this is an UI/UX issue and the app is ok. Since Parallel and Polkadot use the same derivation path, the pubkey is the same and probable polkadot-js just detects that and doesn't compare the addresses. [...]

jacogr commented 1 year ago

Sadly this is something I cannot replicate, and that not investigate nor fix (if there is indeed an issue) -

Don't have access to Ledger, so cannot do step 1 nor step 2

Having said that, Ledger accounts should only be visible based on the genesisHash, i.e. only available on networks with the specified genesis.

If this continues being an issue, a PR is appreciated, i.e. something that is tested on the contributing side.

And yes, if the underlying pubkey is the same, there will only be one address - the UI certainly does not differentiate based on encoding of the address and never will. Fot the same pubkey there will only ever be a single entry, this is expected and intended.