what happened to Blake2s implementation in util-crypto

polkadot-js / common

Utilities and base libraries for use across polkadot-js for Polkadot and Substrate. Includes base libraries, crypto helpers and cross-environment helpers.

Apache License 2.0

255 stars 146 forks source link

what happened to Blake2s implementation in util-crypto #1039

Closed kkast closed 3 years ago

kkast commented 3 years ago

Hi! at the moment '@polkadot/util-crypto' only provides blake2AsU8a which is blake2b. there was a pr https://github.com/polkadot-js/common/pull/66/files#diff-67db38e15c39a4981b3e9bae48f7862ff87fca1080fc2abd3904bb12a2800be8R34 which had Blake2s added. On the substrate side, there is an opportunity to use blake2s. Could you please tell me if there is an implementation of blake2s by polkadot-js, and if not, was there particular reason to remove it. Are there recommendations to use blake2b? If no, what package would be considered good to be used for blake2s with up to date support? Thank you for your time!

jacogr commented 3 years ago

I will need to look at the history - but if I had to guess (without looking at the PRs), it was because Substrate only uses 2b. So basically 2s was “unused”.

The Blake-JS package works really well.

Can certainly add 2s back if there is a need.

kkast commented 3 years ago

@jacogr thank you very much for your response! Are you referring https://github.com/dcposch/blakejs? in substrate there is pallet called blake2 and it also support Blake2s. Is it recommended to use Blake2b on substrate?

jacogr commented 3 years ago

Yes, on the JS side it either uses -

blakejs (when WASM is not available, as linked by you), or
Rust blake2_rfc via WASM (when WASM is available, same crate as in Substrate)

I cannot say what is recommended, only that Substrate/Polkadot only uses 2b everywhere Blake is used (which is the default for all hashing operations).

polkadot-js-bot commented 3 years ago

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

polkadot-js-bot commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.