search

polkadot-js / common

Utilities and base libraries for use across polkadot-js for Polkadot and Substrate. Includes base libraries, crypto helpers and cross-environment helpers.
Apache License 2.0
254 stars 147 forks source link

Adds matrixchain to ss58 tests #1924

Closed leonardocustodio closed 3 months ago

leonardocustodio commented 4 months ago

Hello @TarikGul , where do I add the networks to appear when connecting a ledger to the polkadot-js extension? We've added in the other network/genesis/etc files and still can't get to show in the dropdown.

CleanShot 2024-06-25 at 18 10 34@2x

TarikGul commented 3 months ago

Hey @leonardocustodio Thanks for the patience. You need to update the ss58 registry in the actual repo @substrate/ss58-registry package if its not there yet - heres the repo: https://github.com/paritytech/ss58-registry

leonardocustodio commented 3 months ago

@TarikGul I've a PR open in there for some time now, are you able to merge? https://github.com/paritytech/ss58-registry/pull/209

TarikGul commented 3 months ago

I pinged the main maintainer to do a review.

TarikGul commented 3 months ago

I was unaware of the comments made by the original creator of polkadot-js https://github.com/polkadot-js/apps/pull/9870#issuecomment-1851357531, and will be closing this PR since those comments still hold merit. Polkadot-js will only support Polkadot and Kusama as Relay Chains (and their testnets).

polkadot-js-bot commented 3 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.