search

polkadot-js / common

Utilities and base libraries for use across polkadot-js for Polkadot and Substrate. Includes base libraries, crypto helpers and cross-environment helpers.
Apache License 2.0
254 stars 147 forks source link

Add peaq support for ledger #1928

Closed lavish0000 closed 4 months ago

lavish0000 commented 4 months ago

add ledger support for peaq

peaq is listed in -

BIP-0044 - https://github.com/satoshilabs/slips/blob/master/slip-0044.md ledger-substrate-js - https://github.com/Zondax/ledger-substrate-js/pull/115

lavish0000 commented 4 months ago

@jacogr , Can you please review this?

TarikGul commented 4 months ago

This will be out in 13.0.2 shortly

lavish0000 commented 4 months ago

Thank you so much, @TarikGul.

I have another question: When will the ledger icon appear on the Polkadot.js app for peaq or in the Polkadot.js extension list of networks that support ledger devices?

Additionally, do we need to make any changes in other Polkadot.js repositories to add ledger support?

TarikGul commented 4 months ago

Additionally, do we need to make any changes in other Polkadot.js repositories to add ledger support?

As long as you have a running chain is Polkadot.js this is all that is required (I am almost positive, and will let you know otherwise).

When will the ledger icon appear on the Polkadot.js app for peaq or in the Polkadot.js extension list of networks that support ledger devices?

For apps, and the extension it should be the same but its based off of if it identifies the chain as havingLedgerSupport which is enabled based on the configs you passed in in this PR. So you should be alright.

TarikGul commented 4 months ago

Ledger in apps is going to be fixed first this week with the new updates and then the extension. We have to update the interface for how the extension interacts with dApps since it now requires retrieving the metadata blob for constructing the proof to attach to the tx for signing. So you will see incoming PR's to have all this fixed soon.

lavish0000 commented 4 months ago

Thanks for clarifying, @TarikGul

I'm asking because I'm unable to see the ledger icon in Polkadot.js apps and extensions. I ran the Polkadot.js apps locally and found that the issue is due to "@polkadot/networks" needing to be updated to version 13.0.2 for it to work. So basically dependency update is needed.

Do you know how dependency update is usually handled? Does the Polkadot team update it periodically, or do I need to create a pull request (PR) for this?

TarikGul commented 4 months ago

Thanks for clarifying, @TarikGul

I'm asking because I'm unable to see the ledger icon in Polkadot.js apps and extensions. I ran the Polkadot.js apps locally and found that the issue is due to "@polkadot/networks" needing to be updated to version 13.0.2 for it to work. So basically dependency update is needed.

Do you know how dependency update is usually handled? Does the Polkadot team update it periodically, or do I need to create a pull request (PR) for this?

I am actually the one who does all the downstream updates. Everything but apps will be updated by Monday then we will update the common deps in apps Monday/Tuesday, but it also requires a large rework of the Ledger interface in apps, so it wont be immediate.

The release Process is not as straightforward as updating the deps in one place unfortunately everything has layers in PJS - meaning things have to be updated in there tree order: wasm -> common -> api -> phishing -> tools -> ui -> extension -> apps

So it takes a few days to get everything updated tested etc. And in this case because 13.0.2 is going to be a huge change for apps it will take an extra day or so.

lavish0000 commented 4 months ago

Understood. Thanks a lot🙏. This is really helpful. I'll keep my eye on these updates.

polkadot-js-bot commented 4 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.