Remove slip44, and replace with POLKADOT_SLIP

polkadot-js / common

Utilities and base libraries for use across polkadot-js for Polkadot and Substrate. Includes base libraries, crypto helpers and cross-environment helpers.

Apache License 2.0

254 stars 147 forks source link

Remove slip44, and replace with POLKADOT_SLIP #1930

Closed TarikGul closed 4 months ago

TarikGul commented 4 months ago

This removes the slip44 arg from the constructor of LedgerGeneric. Technically to get the interface working you can just set the slip44 for polkadot, for all chains. That becomes a bit confusing and I think is a weird unnecessary interface.

The reason for all of this is because the new ledger app sets all paths for chains addresses to be the polkadot slip44.

polkadot-js-bot commented 4 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.