search

polkadot-js / common

Utilities and base libraries for use across polkadot-js for Polkadot and Substrate. Includes base libraries, crypto helpers and cross-environment helpers.
Apache License 2.0
254 stars 147 forks source link

add ledger configs for encointer and integritee #1938

Closed brenzi closed 2 months ago

brenzi commented 2 months ago

Encointer: shares derivation with Kusama as it is a teleporter systemchain

Integritee: New slip44 registered and derivation path added. Same for our Polkadot and Kusama parachains as the token is the same TEER (about to be bridged)

TarikGul commented 2 months ago

Looks like there is a general issue around the coupling of the hw-ledger lib, with the network defaults. I am on the fence about things but now that the generic app exists, I am in the boat that these tests either: a) need to change, or b) there needs to be some rework done. It really becomes a pita for new chains that want to onboard their chains to use ledger in apps.

brenzi commented 2 months ago

pita indeed. awaiting these should make CI pass:

brenzi commented 2 months ago

@TarikGul It seems the above PR's aren't necessary according to zondax becasue we will use the generic app. May I ask you to adjust the CI tests accordingly?

https://github.com/Zondax/ledger-substrate-js/pull/134#issuecomment-2341553093

TarikGul commented 2 months ago

Yea, I'll work on cleaning that up today for you!

TarikGul commented 2 months ago

To make things easier I wrote a replacement PR to avoid all the linter and test errors: https://github.com/polkadot-js/common/pull/1939 - It is a extension of you PR :), Thanks again for your patience

TarikGul commented 2 months ago

I'll make sure to release this and get this part of the release cycle next week so it can make it to the extension etc.

TarikGul commented 2 months ago

Closing in favor of: https://github.com/polkadot-js/common/pull/1939

polkadot-js-bot commented 2 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.