search

polkadot-js / extension

Simple browser extension for managing Polkadot and Substrate network accounts in a browser. Allows the signing of extrinsics using these accounts. Also provides a simple interface for compliant extensions for dapps.
Apache License 2.0
974 stars 417 forks source link

Allow QR signing and add error when the account has no genesis #1155

Closed Tbaut closed 2 years ago

Tbaut commented 2 years ago

This PR reverts https://github.com/polkadot-js/extension/pull/1053 now that Signer supports raw bytes signing again thanks to https://github.com/paritytech/parity-signer/pull/1332

Small bonus, I added an error message in case the account has no genesisHash associated. This is mandatory for QR generation and is a common source of confusion. Before having this message, the screen would only show the bytes, with no signing button or QR code, leaving users with no clue about what's going on.

I tested it with Signer master branch, Polkassembly and the Signing tool of apps.

image image image

mustermeiszer commented 2 years ago

Thanks for being so fast @Tbaut!

@jacogr any estimates when this will hit the public chrome extension?

polkadot-js-bot commented 2 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.