polkadot-js / extension

Simple browser extension for managing Polkadot and Substrate network accounts in a browser. Allows the signing of extrinsics using these accounts. Also provides a simple interface for compliant extensions for dapps.
Apache License 2.0
964 stars 403 forks source link

Raw signing with polkadot.js and parity signer is not possible due to outdated polkadot.js extension version in Chrome and Firefox stores #1268

Open nud3l opened 1 year ago

nud3l commented 1 year ago

Judging from https://github.com/paritytech/parity-signer/pull/1332 and https://github.com/polkadot-js/extension/pull/1155, I was expecting that I can sign raw data using accounts in the parity signer via polkadot.js.

However, when I try to sign raw data, I get "Raw data signing not supported for QR wallets" error:

image

When injecting the same account with the parity signer companion extension, I can sign raw data.

Polkadot.js extension and the signer companion should behave the same.

nud3l commented 1 year ago

I'm thinking it might be related that the versions in the firefox and chrome store 0.44.1 are older than the version in which the fix #1155 is included?

Tbaut commented 1 year ago

Indeed, building from master will allow you to sign raw messages. The live extension hasn't got a release since the fix was merged.

nud3l commented 1 year ago

Is there any plan to update the version in the Firefox and Chrome stores? I have no issue with updating the polkadot.js, but our average users that use the polkadot signer likely will not go through that.

jpangelle commented 9 months ago

FYI, this is also creating an issue for Talisman too since they use the polkadot extension logic:

Currently Talisman inherits its signing logic directly from the polkadot.js extension.

Source

bkchr commented 8 months ago

@jacogr would it be possible to get a release out?

FlorianFranzen commented 3 months ago

@bkchr There has not been no new release in over 2 years! Could we please do something about it? (see #1291 for discussion)

kianenigma commented 3 months ago

any updates on this? Quite a blocker for many ppl it seems.

In the short term, @Tbaut has told me the only way so to build a custom version of the extension. Do you have the code for that in a fork that we can use?

Tbaut commented 3 months ago

If you build master following these instructions, you'll be able to run the latest version of the extension and benefit from the features that have been added in the past years.

bkchr commented 3 months ago

We don't have access to the chrome nor firefox stores. I'm on it, but maybe we need to bite the bullet and create a new extension.

ggwpez commented 2 months ago

I think Talisman + Parity Signer can sign raw data.

TarikGul commented 2 months ago

We don't have access to the chrome nor firefox stores. I'm on it, but maybe we need to bite the bullet and create a new extension.

I like the idea of us having a backup plan. Maybe we can decide a hard date where if we don't get access by then we can start the transition to a new release under a different extension with a migration guide.

IkerAlus commented 2 days ago

This should be already fixed for Chrome version and (hopefully) also solved for Firefox version in the next days

kianenigma commented 2 days ago

Yeah, confirming that I have the new version on chrome now ✅