search

polkadot-js / extension

Simple browser extension for managing Polkadot and Substrate network accounts in a browser. Allows the signing of extrinsics using these accounts. Also provides a simple interface for compliant extensions for dapps.
Apache License 2.0
973 stars 417 forks source link

Upgrade `web3` dependency in `extension-compat-metamask` #1340

Closed gdethier closed 5 months ago

gdethier commented 6 months ago

We are relying on extension-compat-metamask in our project to interact with MetaMask. However, the old web3 dependency triggers dependabot alerts that can't be solved without upgrading.

We built a custom package from the code in this PR (happy to remove it as soon as a new release contains this change) for testing the upgrade and everything seems to work as expected.

gdethier commented 5 months ago

@TarikGul done (rebased on current main and deduped).

gdethier commented 5 months ago

@TarikGul could you approve the merge? Otherwise, there will be conflicts again...

TarikGul commented 5 months ago

@gdethier Yes I will merge this today, and dont worry no other PR will go in before this. I just need to double check the changes between the web3 versions.

gdethier commented 5 months ago

Great, thanks!

polkadot-js-bot commented 5 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.