polkadot-js / extension

Simple browser extension for managing Polkadot and Substrate network accounts in a browser. Allows the signing of extrinsics using these accounts. Also provides a simple interface for compliant extensions for dapps.
Apache License 2.0
977 stars 414 forks source link

Ensure Generic Ledger Accounts can use "Allow use on any chain" #1439

Open TarikGul opened 3 months ago

TarikGul commented 3 months ago

Since the Extension now supports both the generic and migration app there is no way to distinquish whether an account has the old bip32path or the new one which has the slip44 for only polkadot. Because of this we currently don't have a concrete way to allow the Allow use on any chain functionality for generic app accounts.

It would be nice to find a solution on how we can identify an account as a generic app ledger account, then allow the use of the generic chain feature.

Nick-1979 commented 3 months ago

Why not adding a isGeneric field to AccountJson?

TarikGul commented 3 months ago

We have thought about it, the one thing would be accounts that are already uploaded on the extension won't have that field it would only be accounts that are newly added.

Which is a small edge case - so it's definitely an option

LukeWheeldon commented 1 day ago

I am unable to add both a Polkadot and a Kusama Ledger account using the same seed, simultaneously. Every time I need to switch chain, I need to reconnect the Ledger and re-add the account. I assume "Allow use on any chain" could probably fix this issue.