search

polkadot-js / ui

Re-usable browser libraries and React UI components used inside the polkadot.{js} family of Polkadot and Substrate applications. Full documentation & examples available
https://polkadot.js.org/ui/
Apache License 2.0
121 stars 75 forks source link

Support for Moonbeam addresses in Signer + Extension #693

Open montekki opened 2 years ago

montekki commented 2 years ago

With the start of development of support for Eth-like addresses in Signer in paritytech/parity-signer#1268 we've found out that adding these arrds from Signer into the Extension with QR codes does not work. The format that we are using now is ethereum:ETH_KEY:GENESIS_HASH just like substrate:SS58_KEY:GENESIS_HASH for any other network

Full working support of Ethereum addresses and keys between Signer and Polkadot-js

So people could use Signer on Moon* networks.

polkadot-js-bot commented 2 years ago

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

jacogr commented 2 years ago

Most probably needs to move to the ui repo - QRs are parsed in the react-qr package ( as I recall).

EDIT: Indeed, there is only Substrate support (prefix being the substrate constant), https://github.com/polkadot-js/ui/blob/7d9fb9071184b7e620681df59c69444654aaabd7/packages/react-qr/src/util.ts#L31-L33

So would have some bubble-up effects in the display component as well where it would need additional flags (and then finally to the users of these components). Most probably needs some optional (important, needs backwards compat for existing users) flag to indicate anything that is non-Substrate prefixed.