search

polkascan / py-bip39-bindings

Python bindings for tiny-bip39 RUST crate
Apache License 2.0
4 stars 8 forks source link

Bump pyo to 0.10.1 due to removed feature gate #3

Closed step21 closed 3 years ago

step21 commented 3 years ago

When compiling on latest rust nightly and stable, this was broken due to some feature gates being changed. This seems to work fine with a slight bump for pyo. (bump to 13.x not possible due to pyo api changes) So far tested mostly on arm but should be similar for other archs.

arjanz commented 3 years ago

Thanks for the PR!

step21 commented 3 years ago

Of course, thanks for merging! Do you know when/if this will end up on pypi?

arjanz commented 3 years ago

Last week I already uploaded the py_bip39_bindings-0.1.6-cp3*-cp3*m-macosx_11_0_arm64.whl wheels, I guess I need to find specific ARM runners to create these binaries for Win/Linux? Or is recompiling for manylinux1 enough (the Github action runners are x64 I guess)

step21 commented 3 years ago

I think for now a current source tar ball on pypi would suffice. Then that is used in case no suitable wheel is found. It just needs a version bump with these latest changes for all the three bindings. If you want to do wheels, at least in theory linux can cross compile, but not sure if this is activated in these github runners. For Windows I am not sure arm is widespread enough that it makes sense. In case you are considering custom runners now or in the future, there is this action https://github.com/uraimo/run-on-arch-action and projects like conda-forge use drone.io for that or you can also use dockerhub with github actions. (though latter two are probably more work) This might take longer to compile, but with a relatively small packages such as this it hopefully is still ok.

arjanz commented 3 years ago

I have release a new version of all the RUST bindings with new source. I tried this morning to make https://github.com/arjanz/py-bip39-bindings/blob/8469bc2c1763de4ad147f04b0b56ed421d9c1d0e/.github/workflows/ci.yml work, it should be possible but I need to tweak the config some more. But for now you can at least build from source.

step21 commented 3 years ago

That's awesome, thanks! Just tried it in a new virtualenv and seems to work great. Yeah I know how it is, extending/debuggin ci is hard sometimes. Even better if that's a possibility and thanks for all your work!