search

polkascan / py-sr25519-bindings

Python bindings for the RUST implementation of the sr25519 cryptography library
Apache License 2.0
8 stars 16 forks source link

Include Cargo.lock in repo #14

Closed dotlambda closed 1 year ago

dotlambda commented 1 year ago

That would make it easier for distributions to package py-sr25519-bindings. See also https://github.com/rust-lang/cargo/issues/315.

arjanz commented 1 year ago

But what I read in the link you provided is that Cargo.lock should not be included for libraries? (https://github.com/rust-lang/cargo/issues/315#issuecomment-51075730)

Rust docs also state the same: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

dotlambda commented 1 year ago

But what I read in the link you provided is that Cargo.lock should not be included for libraries?

Yes, it shouldn't be included for Rust libraries. Your Python library however is at the end of the Rust dependency chain.