polkascan / py-substrate-interface

Python Substrate Interface
https://polkascan.github.io/py-substrate-interface/
Apache License 2.0
240 stars 116 forks source link

SubstrateInterface get_runtime_metadata potential typo #134

Closed JacquesBermanWebster closed 3 years ago

JacquesBermanWebster commented 3 years ago

Hello. I think I found a typo in SubstrateInterface class, get_runtime_metadata method.

There is this block of code: metadata_decoder = self.runtime_config.create_scale_object( 'VersionedMetadata', data=ScaleBytes(response.get('result'))) And I believe it should go like this metadata_decoder = self.runtime_config.create_scale_object( 'MetadataVersioned', data=ScaleBytes(response.get('result')))

arjanz commented 3 years ago

You are absolutely right, thanks for reporting!

JacquesBermanWebster commented 3 years ago

You're welcome. Thanks for quick response and fix!