search

polkascan / py-substrate-interface

Python Substrate Interface
https://polkascan.github.io/py-substrate-interface/
Apache License 2.0
240 stars 111 forks source link

Keypair: set ss58_format default to 42 #312

Closed M5oul closed 1 year ago

M5oul commented 1 year ago

as mentioned in the documentation 42 ss58_format is for test currencies

Fix tests by providing expected ss58_format.

M5oul commented 1 year ago

Documentation fixed.

arjanz commented 1 year ago

Sorry for the late reply. I looked into your PR before, it made sense, but I saw some possible issues with the change with existing usage of the lib. Before it was not required, but now it could potentially raise exceptions because when a ss58_format is set, the address is checked if the provided ss58_format is valid.