Closed remzrn closed 4 years ago
Commit 9d5bfff70389fb6b772a1deb8784dfde3d9e05f0 in the develop branch seems to break sending transactions without a proxy account because the variable _proxyAccount could be null on these lines: https://github.com/polkawallet-io/polkawallet-flutter/blob/develop/lib/page/account/txConfirmPage.dart#L144 https://github.com/polkawallet-io/polkawallet-flutter/blob/develop/lib/page/account/txConfirmPage.dart#L153 In the version that handles Edgeware, I quick-fixed it by checking for null and returning false in the first function, and changing the condition guard to ensure it does not enter the first branch if there is no proxy, and _proxyAccount is null. Not issuing a pull request, because I am not sure it handles all the cases at this point.
Commit 9d5bfff70389fb6b772a1deb8784dfde3d9e05f0 in the develop branch seems to break sending transactions without a proxy account because the variable _proxyAccount could be null on these lines: https://github.com/polkawallet-io/polkawallet-flutter/blob/develop/lib/page/account/txConfirmPage.dart#L144 https://github.com/polkawallet-io/polkawallet-flutter/blob/develop/lib/page/account/txConfirmPage.dart#L153 In the version that handles Edgeware, I quick-fixed it by checking for null and returning false in the first function, and changing the condition guard to ensure it does not enter the first branch if there is no proxy, and _proxyAccount is null. Not issuing a pull request, because I am not sure it handles all the cases at this point.