search

polkawallet-io / sdk

polkawallet SDK for integrating substrate-based blockchain as a plugin.
Apache License 2.0
18 stars 24 forks source link

FIX: Runtime type errors #36

Closed L3odr0id closed 1 year ago

L3odr0id commented 1 year ago

There are several lines with typecast errors. The errors appear sometimes in runtime

poka-IT commented 1 year ago

Yes, if you check the 2 others MR, you will see we are fixing the same thing, but @RomeroYang doesn't seem to want to fix this problem...

L3odr0id commented 1 year ago

Oh, I see. That's sad

RomeroYang commented 1 year ago

The typecast was auto generated by another developer while doing null-safety rebuild with script. I don't know why but it works well in polkawallet since then 😂.

RomeroYang commented 1 year ago

fixed with PR #35

L3odr0id commented 1 year ago

@RomeroYang , actually the bug in lib/api/apiAssets.dart was not fixed in #35. Please, check this: https://github.com/L3odr0id/polkawallet_sdk/commit/3eb28f1dfcfd4d122c50ba70e6c7406cced5a0b5