polkit-github-migration-bot / t4_polkit

Other
0 stars 0 forks source link

Enable structured logging output #69

Open polkit-github-migration-bot opened 8 years ago

polkit-github-migration-bot commented 8 years ago

In gitlab.freedesktop.org by bugzilla-migration on Aug 14, 2016, 14:10

Link to the original issue: https://gitlab.freedesktop.org/polkit/polkit/-/issues/67

Submitted by Philip Withnall

Assigned to David Zeuthen @david

Link to original bug (#97342)

Description

Using the new GLib structured logging support, send structured log messages to journald. This simplifies polkit's logging code a little, and allows more information to be sent to the journal. Specifically, MESSAGE_IDs can now be sent; and connecting directly to the journal means it will get the right process information.

This bumps the GLib dependency to 2.49.4.

polkit-github-migration-bot commented 8 years ago

In gitlab.freedesktop.org by bugzilla-migration on Aug 14, 2016, 14:10

:hammer_and_wrench: Philip Withnall submitted a patch:

This bumps polkit's GLib dependency to 2.49.4, but enables new features such as message IDs for log messages, inclusion of various key parameters as separate fields, and (probably most importantly) coloured log output.

A custom log writer function is used to preserve the original behaviour of outputting everything to the journal, and outputting debug messages to stdout unless --no-debug is specified.

Patch 125778, "polkitbackend: Enable structured logging output":
polkitbackend-Enable-structured-logging-output.patch

polkit-github-migration-bot commented 8 years ago

In gitlab.freedesktop.org by bugzilla-migration on Aug 14, 2016, 14:10

:hammer_and_wrench: Philip Withnall submitted a patch:

Patch 125779, "polkitbackend: Fix typos in a couple of initialisation error messages":
polkitbackend-Fix-typos-in-a-couple-of-initialisat.patch

polkit-github-migration-bot commented 8 years ago

In gitlab.freedesktop.org by bugzilla-migration on Aug 14, 2016, 14:10

:hammer_and_wrench: Philip Withnall submitted a patch:

Use G_LOG_USE_STRUCTURED to ensure that the structured logging mode is used.

Patch 125780, "src: Switch from g_print() to g_log()":
src-Switch-from-gprint-to-glog.patch

polkit-github-migration-bot commented 6 years ago

In gitlab.freedesktop.org by bugzilla-migration on Apr 3, 2018, 20:27

:speech_balloon: Ray Strode @halfline said:

Pushing the easy patch now, the other patches still need review.

Attachment 125779 pushed as 743eef5 - polkitbackend: Fix typos in a couple of initialisation error messages