polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
71 stars 34 forks source link

[PATCH] configure: fix elogind support #30

Open polkit-github-migration-bot opened 6 years ago

polkit-github-migration-bot commented 6 years ago

In gitlab.freedesktop.org by bugzilla-migration on Apr 11, 2018, 13:58

Link to the original issue: https://gitlab.freedesktop.org/polkit/polkit/-/issues/29

Submitted by Rasmus Thomsen

Assigned to David Zeuthen @david

Link to original bug (#105989)

Description

Created attachment 138756 0001-configure-fix-elogind-support.patch

HAVE_LIBSYSTEMD is used to determine which source files to use. We have to check if either have_libsystemd or have_libelogind is true, as both of these need the source files which are used when HAVE_LIBSYSTEMD is true. Without this patch the necessary files are only included if systemd is present, which breaks polkit on systems with elogind.

Patch 138756, "0001-configure-fix-elogind-support.patch":
0001-configure-fix-elogind-support.patch

See also

polkit-github-migration-bot commented 6 years ago

In gitlab.freedesktop.org by bugzilla-migration on Apr 12, 2018, 08:07

:speech_balloon: Sven Eden said:

I apologize for not having spotted this when I updated the integration patch to only touch configure.ac for bug #98688. Sorry everybody!

polkit-github-migration-bot commented 6 years ago

In gitlab.freedesktop.org by bugzilla-migration on Apr 12, 2018, 08:08

:speech_balloon: Sven Eden said:

@Ray: Can this be released as a hotfix?

polkit-github-migration-bot commented 4 years ago

In gitlab.freedesktop.org by pierre on Aug 20, 2020, 18:42

This is still present in 0.117

polkit-github-migration-bot commented 4 years ago

In gitlab.freedesktop.org by xry111 on Aug 20, 2020, 19:24

This is really troubling. We hit this issue and debugged for 2 days, then track it down here.

I suggest to release 0.117.1 with this patch, and also including #127 fix (!62).

polkit-github-migration-bot commented 4 years ago

In gitlab.freedesktop.org by pierre-labastie on Sep 17, 2020, 14:28

And still present in 0.118... This is a one line obvious change. What is the problem?