search

polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
41 stars 22 forks source link

Add CI test case for polkit - systemd integration #439

Closed msekletar closed 1 month ago

msekletar commented 3 months ago

Is your feature request related to a problem? Please describe. This RFE is motivated by #206.

Describe the solution you'd like Simple automated test (something along the lines of reproducer from #206) for this use-case to prevent future regressions.

Describe alternatives you've considered I think this functionality should be tested in upstream but in case this request can't be fulfilled for any reason I will seek solution on distribution level (Fedora).

Additional context Polkit rules for systemd unit management are often used feature and it would be great to have test coverage for it in upstream CI.

jrybar-rh commented 3 months ago

Hello @bluca,
Can you cover this, please?

bluca commented 3 months ago

There's no test infrastructure in place to do anything like that, it would be a huge task and I'm afraid I just don't have the time for that, sorry

jrybar-rh commented 3 months ago

Ok, from what I've seen in monitoring of dbus, it looks like the dbusmock needs to be updated to provide response for the new GetConnectionCredentials method. I'm exploring the dbusmock settings right now.

jrybar-rh commented 1 month ago

Fixed in f510b3f

Thanks, @mrc0mmand!