search

polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
41 stars 22 forks source link

Macro housekeeping #448

Closed notpeelz closed 2 months ago

notpeelz commented 2 months ago

  1. I removed feature test macro definitions (i.e _GNU_SOURCE/_XOPEN_SOURCE) from polkitbackend because _GNU_SOURCE is already defined in the root meson.build. Explicitly defining _XOPEN_SOURCE is redundant because _GNU_SOURCE implies _XOPEN_SOURCE 700 (according to the comments in glibc's features.h)

  2. I simplified the handling of config.h; instead of having #include "config.h" in every file, we can use the compiler's -include option to do that for us I had to bump the meson version requirement to >=1.4.0 to use the file.full_path() API.

  3. I moved the -std=c99 flag to the project's default_options, as it appears to have been fixed (https://github.com/mesonbuild/meson/pull/10170)

vmihalko commented 2 months ago

Hello, thank you for your contributions! Could you please create a separate PR for each change (item in your description)?

notpeelz commented 2 months ago

I initially had them as separate commits, but decided to squash them because the changes are tightly coupled. I'll try to split them into stacked PRs.

notpeelz commented 2 months ago

Change #2 split into #454 Change #1 split into #455 (depends on #454)

I'll make a new PR for change #3 once #454 is merged, so to avoid unnecessary merge conflicts.