polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
51 stars 30 forks source link

test: skip if the namespace cannot be set up due to permissions or if python3 is too old #485

Closed bluca closed 2 weeks ago

bluca commented 1 month ago

On some build systems, like Debian's, the tests do not have permissions to create new namespaces, so skip gracefully in that case

Follow-up for 8e17f09c770bc2efd5deb40ba2b6032d40603578

jrybar-rh commented 3 weeks ago

@mrc0mmand Skip or fail the test if the user doesn't have permission to run it?

bluca commented 3 weeks ago

Let's not fail please, as it breaks package builds. Hit this issue after uploading the new version to Debian. We skip tests that require privileges in systemd too.

mrc0mmand commented 3 weeks ago

Yeah, I think skipping the tests in such case is reasonable.