search

polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
65 stars 32 forks source link

Add meson option to use gettext for translations in .policy files #486

Closed bluca closed 2 weeks ago

bluca commented 2 months ago

Disabled by default. Will be used in Debian/Ubuntu and derivatives, where this patch has been carried out-of-tree for ~15 years.

Fixes https://github.com/polkit-org/polkit/issues/35

zerocool438 commented 2 months ago

Operating system fedora 40. After this patch is installed, the policy prompt is correct for the first time every time the polkit service is restarted. After that, only English is displayed.

zerocool438 commented 2 months ago

@robert-ancell @bluca

zerocool438 commented 2 months ago

systemd : 255.10-3.fc40 polkit: 124-2.fc40

zerocool438 commented 2 months ago

1、sudo systemctl restart polkit.service 2、timedatectl set-timezone Asia/Singapore 微信图片_20240823111301

After that, Execute "timedatectl set-timezone Asia/Singapore" again. 微信图片_20240823111310

bluca commented 2 months ago

@zerocool438 thanks for testing - could you please try again with this new version just pushed?

zerocool438 commented 2 months ago

@zerocool438 thanks for testing - could you please try again with this new version just pushed? I'll give it a try.

zerocool438 commented 2 months ago

@zerocool438 thanks for testing - could you please try again with this new version just pushed? I noticed that you added judgment to the result value. I can just tell you the result value in these two executions. source code: 截图 2024-08-26 15-28-27 journal: 截图 2024-08-26 15-25-21

@bluca

bluca commented 2 months ago

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

zerocool438 commented 2 months ago

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

No, this PR didn't fix it.

zerocool438 commented 2 months ago

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

The phenomenon remains the same.

bluca commented 2 months ago

Ok thanks, I've switched this to a disabled-by-default meson option. We can enable this in Debian and derivatives, and it can be kept disabled in Fedora and derivatives.

bluca commented 2 weeks ago

@jrybar-rh gentle ping - this is disabled by default so shouldn't affect Fedora, but it would allow us in Debian/Ubuntu to drop a downstream patch that we have been carrying for more than 10 years. Thanks!