polkit-org / polkit

polkit (formerly PolicyKit) is a toolkit for defining and handling authorizations. It is used for allowing unprivileged processes to speak to privileged processes.
Other
51 stars 30 forks source link

Fix missing arguments with HAVE_PTHREAD_CONDATTR_SETCLOCK #491

Closed sertonix closed 3 weeks ago

sertonix commented 1 month ago

Summary

482 added a new argument to polkit_backend_authority_log but it wasn't added to the calls inside of the HAVE_PTHREAD_CONDATTR_SETCLOCK ifdef.

Detailed description and/or reproducer

Otherwise the polkit package on alpine linux edge fails to build: https://gitlab.alpinelinux.org/sertonix/aports/-/jobs/1479902

../src/polkitbackend/polkitbackendduktapeauthority.c:776:35: error: passing argument 2 of 'polkit_backend_authority_log' makes integer from pointer without a cast [-Wint-conversion]
  776 |                                   "Error setting condition variable attributes: %s",
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   |
      |                                   char *