search

pollen-robotics / dtw

DTW (Dynamic Time Warping) python module
GNU General Public License v3.0
1.16k stars 233 forks source link

Recommending a name change of the fastdtw() function #25

Closed cmuell89 closed 6 years ago

cmuell89 commented 6 years ago

A DTW variation called FastDTW is becoming an established technique in DTW literature, reducing the algorithm to a O(n) complexity: https://pdfs.semanticscholar.org/05a2/0cde15e172fc82f32774dd0cf4fe5827cad2.pdf

The fastdtw function name is confusing if a user is assuming that it implements the technique in the FastDTW paper. The current implementation is using the cdist() function from SciPy, which is an accelerated distance calculation function and not the same as the technique in the paper.

Perhaps accelerated_dtw() ?

pierre-rouanet commented 6 years ago

Thanks for letting me know! I'll make the change asap.

cmuell89 commented 6 years ago

If you're curious to see an implementation, here is one: https://github.com/slaypni/fastdtw