pollen-robotics / gst-signalling-py

Python implementation of the Gstreamer signalling
Apache License 2.0
1 stars 0 forks source link

34 get producer list cannot be called from thread #35

Closed FabienDanieau closed 10 months ago

FabienDanieau commented 10 months ago

I changed

    loop = asyncio.get_event_loop()
    return loop.run_until_complete(get_list())

to return asyncio.run(get_list())

since I am calling the function from a thread (with no async loop). The example src/example/get_producer_list.py is fixed accordingly (and it was also not working)

Is that ok? or do we want to call get_producer_list in utils from a async function? So the loop would already exist and async.run would not work

github-actions[bot] commented 10 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3 3 100% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: b4651de by action🐍

pierre-rouanet commented 10 months ago

Hum... I may have fixed that the same way you did locally and never pushed the commit...

Thanks for doing it :)