pollen-robotics / reachy2-sdk

Reachy 2 Python SDK
https://www.pollen-robotics.com
Apache License 2.0
5 stars 0 forks source link

322 lidar safety cannot be set #323

Closed simheo closed 3 months ago

simheo commented 4 months ago

The lidar safety could not be set because the grpc stub MobileBaseUtilityServiceStub was used to call the grpc method SetZuuuSafety instead of MobileBaseLidarServiceStub.

I added safety_distance and critical_distance as optional arguments as sending a LidarSafety message without them would set their value to 0.0 which is then interpreted as request to 0.0 in the zuuu hal. I you prefer @glannuzel not to let the user the ability to change these values from the sdk level we can also always send the safety and critical distances attributes of the Lidar object.

github-actions[bot] commented 4 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
754 712 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: e224b11 by action🐍