search

pollen-robotics / reachy_2023

Reachy 2023 workspace
Apache License 2.0
18 stars 9 forks source link

automate installation of reachy-sdk-api ? #137

Open cdussieux opened 1 year ago

cdussieux commented 1 year ago

We could install it through setupy.py of reachy-sdk or through any kind of dependencies management

For now reachy_sdk cannot launch if we do not pull this repo (in ~/dev/ by example) to install it manually

any thoughts on this ?

pierre-rouanet commented 1 year ago

Is it not already the case?

https://github.com/pollen-robotics/reachy-sdk/blob/main/setup.py#L23

cdussieux commented 1 year ago

Ok mb !

Got an issue with reachy-sdk-api because it was not up-to-date and building reachy2023 with colcon did not updated it, so i assume that it was not linked.

I think the proper solution is to upgrade version of package on reachy-sdk-api repository + upgrade minimum requirements on reachy_2023/reachy_sdk_server

Otherwise everyone with an already installed reach-sdk-api will have the issue and need to re install package manually

Maybe, we could also enforce rules on dependencies repository so that changes implies changes in version, even minor ?

cdussieux commented 1 year ago

We may close this one as invalid and take 'version' action in a separate issue