search

pollfish / docs

Documentation for Pollfish.com
6 stars 11 forks source link

[webplugin.md] Update JQuery version in example #8

Closed Malvoz closed 4 years ago

Malvoz commented 5 years ago

Change JQuery version from 1.11.2 to 3.4.1 .

Motivation: Developers tend to copy/paste from examples, and JQuery 1.11.2 has known security vulnerabilities, see https://snyk.io/test/npm/jquery/1.11.2 for details.

Also, the newer version is 6kb~ smaller 🎉

nikosrossolatos commented 5 years ago

Hi @Malvoz ,

thanks for the PR. As we've also discussed in another ticket, removing JQuery completely is more preferable than having to update the JQuery version on the documentation. Incorporating it inside the same webplugin and maintaining ourselves is also a thing we are discussing. For now, i wont merge this change in JQuery because i would need to test it first through our QA.