search

pollfish / docs

Documentation for Pollfish.com
6 stars 11 forks source link

[bug] Web Plugin: Avoid known blocked id's/classes. #9

Open Malvoz opened 5 years ago

Malvoz commented 5 years ago

Adblockers (in this case: https://getadblock.com/) inject stylesheets, setting the display property to none for certain CSS selectors.

The Pollfish Web Plugin is affected by this stylesheet injection. The injected style: gdpr:not(body):not(html) { display: none !important } makes the entire element that wraps the "I agree" button (start survey) invisible to the users as shown below:

pollfish-blocked .

While there are alot of filters, the one that includes the blocking style comes from: https://easylist-downloads.adblockplus.org/fanboy-annoyance.txt

As an exmaple, changing the Web Plugin's gdpr class to gdpr-info makes the content visible again.

I also tested the web plugin with uBlock Origin with no issues, as far as I can tell.

nikosrossolatos commented 5 years ago

@Malvoz nice work here ! I'll make a ticket to check against all css classes to fix this case (in case some went missing). Leaving this open so that we keep track of it