search

pollination / pollination-sample-models

A repository for sample models that are created by Pollination Rhino and Revit plugins
0 stars 0 forks source link

Sydney_Opera_House.xml has a few gaps due to missing vertices #1

Open Tokarzewski opened 1 year ago

Tokarzewski commented 1 year ago

The Sydney_Opera_House.xml file has a few non-watertight gaps. I have attached a screenshot below from spider gbXML for reference.

image

There are a few neighbouring surfaces that seem to be missing vertices. I will describe one case as an example. These three faces (Face_82b0b0f9_92, Face_82b0b0f9_93 and Face_82b0b0f9_107) are supposed to be adjacent and have shared vertices, but the Face_82b0b0f9_107 is missing a vertex.

image image

Vertex coordinates are written with the 6 decimal places (0.000001), but adjacent edges are not aligned with 6 decimal places. The precision must be lowered to 3 decimal places (0.005) or 2 (0.01) for these edges to be aligned.

Adding these missing vertices should help with importing gbXML.

mostaphaRoudsari commented 1 year ago

Hi @Tokarzewski, Thank you for digging into this issue. I imagine this is for helping with the DesignBuilder import.

I'm adding @chriswmackey to this issue to see if there is anything that we can do here based on your comments or if is this something that happens inside the Revit API.

I hope we get a chance to implement the DBXML export sooner rather than later to have a reliable workflow between Pollination and DesignBuilder once and for all.

Tokarzewski commented 1 year ago

Hi @mostaphaRoudsari :)

I've seen the "Exporting the Sydney Opera House model to..." YouTube video and the geometry issues that you encountered while importing the discussed gbXML in DesignBuilder. Multiple zones were open and not closed manifolds (Like open and closed BREPs in Rhino). The issue that I am explaining above is my effort to pinpoint the source of the issue. In DesignBuilder we can lower the tolerance and add missing vertices for neighbouring surfaces in order to close topological "shells" and handle this issue.

Nevertheless, I am reporting the issue here too, so that you know what is wrong with this particular gbXML. I don't know at which stage this issue is happening nor what was the full transition path. Revit -> Polination (HBJSON) ->OpenStudio (osm) -> gbXML ? I only know that Sydney_Opera_House.xml was exported with OpenStudio. <CreatedBy programId="openstudio" date="2023-08-30T18:35:44-04:00" personId="unknown" /> <ProgramInfo id="openstudio">

I also attach a bunch of files that should help with understanding the issue. Please, let me know if I left something unclear. LBT Sydney.zip

Yes, I am looking forward to this direct HBJSON <-> DBXML interoperability too! :)