search

pollination / queenbee

👑 Queenbee is a workflow language for creating workflows
https://pollination.github.io/queenbee
MIT License
18 stars 5 forks source link

Recipe owner for local recipe #173

Closed MingboPeng closed 3 years ago

MingboPeng commented 4 years ago

The local recipe object doesn't have owner key. Do we want to use maintainer's info for displaying owner on UI?

cc @mostaphaRoudsari

mostaphaRoudsari commented 3 years ago

Good question. I'm not sure about the best approach. Let me think about it.

If we use the local repository, then the response will have an owner but the owner will not necessarily match the one that is available on Pollination. I think this will favor what @AntoineDao was suggesting to also use the Ladybug Tools repository on Pollination for the local recipes.

@AntoineDao, what do you think?

AntoineDao commented 3 years ago

This is a tricky one. I would tend to think that the local package repository on your machine is the owner of the Recipe and that the maintainers is a non-mandatory field that I would only use for enhancing information about the recipe.

In general I would think of an owner as a Pollination only concept. If you want to translate the concept of "the entity that contains a bunch of recipes I want to list from" then I would consider using the word registry. In that sense the folder on your local machine containing all the recipes you want is a registry in the same way that https://api.staging.pollination.cloud/registries/ladybug-tools is the url to a registry named ladybug-tools. It just so happens that on Pollination we know that ladybug-tools is an account and we give each account it's own registry. It is therefore easier to use the same word (ie: owner instead of registry) for the whole Pollination platform.

^ Not sure how much what I'm saying above makes sense. Do let me know if you think this warrants a quick call to clarify 😀

mostaphaRoudsari commented 3 years ago

closing this issue for now. we are not going to use a local repository.