Python 3.5 compatibility: convert path object to str before open()

polm / cutlet

Japanese to romaji converter in Python

https://polm.github.io/cutlet/

MIT License

286 stars 20 forks source link

Python 3.5 compatibility: convert path object to str before open() #18

Closed krackers closed 3 years ago

krackers commented 3 years ago

Only python 3.6+ supports passing os.PathLike object to open(). Converting to string before passing in works on both, and should not affect anything else.

polm commented 3 years ago

Thanks for the PR.

This is a very small change so I am hesitant to reject it, but as 3.5 has already reached end of life and I'm not interested in supporting it I think I'll have to pass on it. If someone reports that they need to run cutlet on 3.5 for some reason I can point them here at least.