search

polm / cutlet

Japanese to romaji converter in Python
https://polm.github.io/cutlet/
MIT License
286 stars 20 forks source link

Cutlet CLI does not work on windows #41

Closed stephenpope closed 5 months ago

stephenpope commented 9 months ago

I know its a demo program but I find it very useful and was surprised when I tried running on windows !

On windows 10 it fails with:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Scripts\cutlet.exe\__main__.py", line 4, in <module>
  File "C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\site-packages\cutlet\cli.py", line 6, in <module>
    from signal import signal, SIGPIPE, SIG_DFL
ImportError: cannot import name 'SIGPIPE' from 'signal' (C:\Users\XXX\AppData\Local\Programs\Python\Python311\Lib\signal.py)

Its seems SIGPIPE is not supported on Windows : https://stackoverflow.com/questions/58718659/cannot-import-name-sigpipe-from-signal-in-windows-10

Thanks!

polm commented 9 months ago

Thanks for the report with details! I don't program on Windows, but if someone wants to submit a PR to fix this I'd be glad to take a look at it.

polm commented 5 months ago

This should be resolved by #43. I just pushed a new version, 0.4.0, that incorporates the fix.

I'll close this, but if it doesn't work let me know and I can reopen it.