chore(build): switch to Poetry

polm / cutlet

Japanese to romaji converter in Python

https://polm.github.io/cutlet/

MIT License

286 stars 20 forks source link

chore(build): switch to Poetry #47

Closed stegayet closed 5 months ago

stegayet commented 5 months ago

This PR aims at switching to Poetry for project management (dependency management, building and publishing artifacts)

Single source of truth for dependency management through pyproject.toml.
Project now uses poetry as a build backend.
Rework GitHub Actions workflows to use Poetry.

Advantages:

We now build wheels for this project.
Test and doc dependencies are now properly set.

TODO

[ ] Add documentation
[ ] Test workflow

polm commented 5 months ago

Hello,

I noticed you opened five PRs in short succession against this repo. This surprised me a bit, since I don't believe we've ever had any interaction before, and as far as I can tell all of your PRs are about cleaning up parts of the repo that basically only I as maintainer interact with.

Can I ask what inspired you to make these PRs?

stegayet commented 5 months ago

Hello, we've never met before, this library is being used in the company I'm working for and we discovered that this library is not pushing wheels to PyPI, so I thought this could be a good addition. I also took the opportunity to do some cleanup/use more modern tooling.

polm commented 5 months ago

Thank you for explaining why you made these PRs. To be honest it was confusing to see a lot of small PRs at one time with no explanation.

I am not interested in using Poetry, so I will close this.

I was confused as to why it mattered whether Cutlet had a wheel since it's a pure Python package. After reading this thread, I understand that even pure Python packages may execute code, and checking that makes them slower than wheels, which can just copy source files. Since the build script here already seems to be building wheels, I haved changed it so they will also be uploaded to PyPI instead of just being ignored.