polodarb / Flashlight-Tiramisu

An application that allows you to smoothly adjust the brightness of the flashlight on some devices on Android 13+
Apache License 2.0
160 stars 9 forks source link

F-Droid inclusion #1

Closed Poussinou closed 1 year ago

Poussinou commented 2 years ago

Hi,

Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app in F-Droid by yourself, would you still agree with the inclusion of your app in F-Droid by the maintainer team?

polodarb commented 2 years ago

Hey, Yes, as it’s community driven, I’ll appreciate the fact it publishing on F-Droid.

By the way, the application still works on Samsung S22 with the latest OneUI beta

licaon-kter commented 1 year ago

;) pls test https://gitlab.com/fdroid/rfp/-/issues/2217#note_1116002575

Also, small request, can you bump gradle to 7.5 since that's released: https://github.com/polodarb/Flashlight-Tiramisu/blob/main/gradle/wrapper/gradle-wrapper.properties#L3 ?

polodarb commented 1 year ago

Hi :) Gradle I updated to the 8th version. But I did not understand what exactly needs to be checked in the first link that you wrote 🤔

licaon-kter commented 1 year ago

@polodarb get the APK and install and test... from that link...

polodarb commented 1 year ago

oh, ok, sorry, the application works, but you need to remove the permission for the camera, it is superfluous. In my last commit, I removed unnecessary permissions

licaon-kter commented 1 year ago

@polodarb We're ready: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11839

All we need is a Fastlane folder structure to hold description, icon, summary, screenshots, changelogs: https://gitlab.com/-/snippets/1895688

polodarb commented 1 year ago

Okay, but please give me some time, I've never worked with Fastlane before :)

licaon-kter commented 1 year ago

@polodarb as I said, you don't work with Fastlane tools, just create the folders and files ;)

polodarb commented 1 year ago

Please check if I did it right

licaon-kter commented 1 year ago

@polodarb sorry for the delay

Rename this to icon.png https://github.com/polodarb/Flashlight-Tiramisu/blob/main/fastlane/metadata/android/en-US/images/app_icon.png

Rename this to 1.txt (it's the versionCode not Name ;)) https://github.com/polodarb/Flashlight-Tiramisu/blob/main/fastlane/metadata/android/en-US/changelogs/1.0.txt

polodarb commented 1 year ago

@licaon-kter done :)

licaon-kter commented 1 year ago

Done :)

licaon-kter commented 1 year ago

@polodarb chances are that the app is build reproducible, can you provide a signed APK for commit baf842b3edfd6b319d68a6c66aea3eadbd94cf3e ?

polodarb commented 1 year ago

@licaon-kter Thank you so much for posting in FDroid ❤️ On account of the last comment - I will publish an update soon

polodarb commented 1 year ago

@licaon-kter Hello, how do I update the app in F-Droid?

licaon-kter commented 1 year ago

It will be picked up by the Checkupdate bot soon ;)

polodarb commented 1 year ago

Oh, okay, thanks :)