pololu / dual-vnh5019-motor-shield

Arduino library for the Pololu Dual VNH5019 Motor Driver Shield
http://www.pololu.com/product/2507
MIT License
50 stars 74 forks source link

remove stopIfFault from Demo code and put in library #6

Closed photodude closed 9 years ago

photodude commented 9 years ago

Function definitions belong in the library (even if they work from the code)

ryantm commented 9 years ago

Hi, @photodude

Thanks for your contribution. I'm not that excited about putting a blocking method like that into the library interface. Generally, people should be handling errors and trying to recover or do some additional shutdown. This change goes somewhat in the opposite direction.

Also, it adds a configured serial port as a dependency to the library, when not everyone might want that.

Ryan

photodude commented 9 years ago

Thanks @ryantm I can see the points not to move that function into the library.