fix! & ref: minor fixes and some refactors - Githubissues

poloniki / quint

Transcription/Chunking/Summarization of audio content.

MIT License

55 stars 20 forks source link

fix! & ref: minor fixes and some refactors #5

Closed V3ntus closed 1 year ago

V3ntus commented 1 year ago

This PR is not meant to be merged as-is, but to provide some feedback and bug fixes on specific areas. For our use case, we were interested in the paragraph chunking specifically, these changes were focused on that function.

Fixes:

fixes a ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() exception while running chunking_text in quint.api.fast caused by incorrect casting of a dataframe (quint.api.fast L110)

Refactors:

quint.api.fast Body is now a dataclass subclassed from pydantic's BaseModel instead of an incorrectly implemented (?) fastapi.Body

Features:

Environment:

adds Pipfile for pipenv setup
Docs:
adds detailed instructions for quint setup within a pipenv
Others:
adds automated Linux deploy script (scripts/deploy.sh)
adds automated FastAPI serving script (scripts/serve_api.py)

poloniki commented 1 year ago

Great work, thanks a lot!