polonskiy / crowdr

Crowdr is a tool for managing multiple Docker containers
MIT License
95 stars 9 forks source link

Loose connection #1

Closed kevinsimper closed 9 years ago

kevinsimper commented 9 years ago

In the readme it says "As you can see, server recreated first. It means that client will lost connection."

That does not make sense, because the first example is the exact same as the one after. The server is started first and then the client is started after.

Also the sentence has to either be

It means that the client will have lost connection

OR

It means that the client will loose the connection.

Both means two completely different things.

I guess you want to say something about that the client has a moment where it can't access the server and you want to avoid that by stopping in reverse order of how they were started to prevent that the link die, before it is recreated.

polonskiy commented 9 years ago

Thanks. English is not my native language. Feel free to send pull requests.

kevinsimper commented 9 years ago

But what do you mean? :)

polonskiy commented 9 years ago

Maybe example from readme is too abstract.

Lets imagine that we have the server listening on port 1000 and the client. docker-compose up -d starts the server a then starts the client. The client connects to the server and keeps the connection open. Second run of docker-compose up -d breaks the connection, because the server goes down first.

kevinsimper commented 9 years ago

But is that a problem? The client goes down just after, merely a second later?

polonskiy commented 9 years ago

It depends on application.

The client goes down just after, merely a second later?

If application does not handle signals properly, it can be 10 seconds

I think that graceful stop is better.