SB opl2 emulation missing certain notes

polpo / picogus

Emulation of ISA sound cards on Raspberry Pi Pico (GUS, SB/Adlib, MPU-401, Tandy, CMS) with USB mouse/joystick support

GNU General Public License v2.0

550 stars 39 forks source link

SB opl2 emulation missing certain notes #46

Closed TerryFi closed 2 months ago

TerryFi commented 3 months ago

In Prince of Persia, the intro music missing some piano notes. Also when games starts "Danger" music piece missing a lot of notes in the piano chord. Issue also present in other emu8905 project, verified by playing VGM of the game in emu8905 based VGM player.
Narrowed it down to a bug in attack rate calculation of emu8950.

perchrh commented 3 months ago

What's this emu8905 you refer to? I tried searching for it but couldn't find any matches.

polpo commented 3 months ago

What's this emu8905 you refer to? I tried searching for it but couldn't find any matches.

emu8950 is the OPL2 emulator used in PicoGUS. I use it because it was optimized for the rp2040-doom project so it can run on the RP2040.

polpo commented 2 months ago

Fixed by #47 and #52. Thanks again @TerryFi!