Compared both the new fix and previous workaround sample audio to hardware opl audio output. Workaround shows inaccurate note attack timing whereas the new fix attack timing shows good accuracy. The inaccuracies were verified to be caused by changes in previous workaround.
polpo
commented
1 week ago
Replaced workaround for https://github.com/polpo/picogus/issues/46 with proper fix from https://github.com/digital-sound-antiques/emu8950. Link to original emu8950 commit https://github.com/digital-sound-antiques/emu8950/commit/570dc998dd83cee87b021e15e1d86da736934393.
Compared both the new fix and previous workaround sample audio to hardware opl audio output. Workaround shows inaccurate note attack timing whereas the new fix attack timing shows good accuracy. The inaccuracies were verified to be caused by changes in previous workaround.