search

polqf / RealmResultsController

A NSFetchedResultsController implementation for Realm written in Swift
MIT License
188 stars 25 forks source link

Support for Realm 1.0? #79

Closed ArtSabintsev closed 8 years ago

ArtSabintsev commented 8 years ago

Realm released 1.0 today.

I'll take a look and see if RRC is compatible with 1.0 out of the box. If it is, I'll open up a PR.

polqf commented 8 years ago

Thanks @ArtSabintsev , highly appreciated!!!

ArtSabintsev commented 8 years ago

There's only a couple minor changes.

You need to change realm.path to realm.configuration.fileURL?.absoluteString and it should be fine. However, this adds optional behavior and you need to handle the else condition. I'm not familiar enough with RRC to make that change confidently.

All I did was make the changes with a force-unwrap realm.configuration.fileURL!.absoluteString and everything compiled, however, that's neither right nor elegant for an OSS solution.

polqf commented 8 years ago

Totally agree with you @ArtSabintsev. I'll try to take a look at it tonight.

ArtSabintsev commented 8 years ago

Just following up.

bettimms commented 8 years ago

It would be great to add support for 1.0 and update pod!

polqf commented 8 years ago

Hi guys, sorry for the delay. Here it is: #80 waiting for review

polqf commented 8 years ago

0.4.4 has been released @ArtSabintsev @bettimms

ArtSabintsev commented 8 years ago

👍