Parameter order of `Match` parameters is inconsistent

polyadic / funcky

Funcky is a Functional Library for C#

https://polyadic.github.io/funcky

Apache License 2.0

19 stars 3 forks source link

Parameter order of `Match` parameters is inconsistent #683

Open bash opened 2 years ago

bash commented 2 years ago

Either and Option both have the error state first:

Either: Match(left, right)
Option: Match(none, some)

The inconsistent one is Result with the error state second:

Result: Match(ok, error)

FreeApophis commented 2 years ago

Is this really relevant, for calls to Match the Labels are "undesirable".

bash commented 2 years ago

I ran into this when I tried to generalize the Match analyzer (#680) to all Either-like monads in Funcky. I'd have to add a special case for Result anyways until we release 4.0, so this is not that important to me.