search

polyadic / funcky

Funcky is a Functional Library for C#
https://polyadic.github.io/funcky
Apache License 2.0
19 stars 3 forks source link

Funcky.XUnit is not compatible with the XUnit 2.5 and 2.6 releases. #777

Closed FreeApophis closed 5 months ago

FreeApophis commented 9 months ago

XUnit has breaking changes in each of the releases. Since we do declare falsley that they are compatbile this results in some very nasty exceptions on executing the tests: 

System.TypeLoadException : Could not load type 'Xunit.Sdk.AssertActualExpectedException' from assembly 'xunit.assert, Version=2.6.3.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c'.

The problem is that we assume that XUnit has a Semantic Versioning, while they explicitly state that they have a different versioning system: "You cannot make a SemVer-based assumption about the scope of changes based on the version."

FreeApophis commented 9 months ago

We should merge #778 to declares this correctly for now.

We should also support current xUnit releases later.

bash commented 9 months ago

Should we do a release of Funcky.Xunit?

FreeApophis commented 9 months ago

I thought we release together with the next Funcky release.