search

polyamspace / mastodon

Custom Mastodon fork used by https://polyam.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

Remove server favicon setting #501

Closed polyamAdmin closed 5 months ago

polyamAdmin commented 5 months ago

Closes #206 Closes #241 Ref #7

This setting has been semi-broken for a while and I don't feel confident in fixing this without making major changes. If there is enough interest I might look back into it, but for now it's not really worth fixing.

Using the branding:generate_app_icons task instead is recommended. Just replace app/javascript/images/logo.svg and app/javascript/images/app-icon.svg with the svg of the icon you want to use and then run RAILS_ENV=production bundle exec rake branding:generate_app_icons \ (Or better in a local dev environment and commit the result to your repo to avoid issues when pulling updates)

polyamAdmin commented 5 months ago

I'm actually not sure if previously uploaded favicons get deleted on cleanups or if that has to be done manually, but the site_uploads dir shouldn't contain too many items, so it shouldn't be a problem either way. The more concerning part is the database entry, which could cause problems should such a feature be reintroduced and the files being deleted.

TL;DR Just leave the files in place.