search

polyamspace / mastodon

Custom Mastodon fork used by https://polyam.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

New grouped notifications not marked as unread #636

Closed polyamAdmin closed 2 months ago

polyamAdmin commented 2 months ago

Steps to reproduce the problem

  1. Create some kind of notification for account A from account B
  2. Switch to account A
  3. Notification not marked as unread

Expected behaviour

New notification should be marked as unread

Actual behaviour

New notification is marked as read

Detailed description

This is a weird one. In both glitch and polyam flavour, notifications are never marked as unread, which means the unread property must be always false for some reason. In the vanilla flavour it does get marked as unread, but only when the window isn't focused. As soon as you move your cursor to the browser window, new notifications get marked as read.

Mastodon instance

N/A

Mastodon version

main

Technical details

No response

polyamAdmin commented 2 months ago

Hmh looks like lastReadId is updated as soon as the notification is loaded in, which sets unread to false.

Seems like this is partially intentional judging by shouldMarkNewNotificationsAsRead