search

polyamspace / mastodon

Custom Mastodon fork used by https://polyam.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

Create a "shared_skins" dir #639

Open polyamAdmin opened 1 month ago

polyamAdmin commented 1 month ago

Pitch

Create a shared skins dir which every flavour can load skins from. Possibly some kind of override diff mechanism for flavour specific changes.

Motivation

Less style duplication and easier to apply changes by not requiring porting.

polyamAdmin commented 1 month ago

Conceptionally, this is rather easy to achieve. The main issue is that skins need to import the flavour specific application.scss file and imports have to have a specific order for skins to work correctly. Unless they are a full-fledged customisations of the main style, which is an unreasonable ask. There are ways around this, but it requires some duplication.

polyamAdmin commented 1 month ago

The original idea was to change how skins are loaded to automatically add shared skins to all flavours, without having to duplicate anything, but there is no way to know which application.scss needs to be included at compile time. Therefore a simple structural change is probably the way to go here.