polyamspace / mastodon

Custom Mastodon fork used by https://polyam.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

Keep different message for cancelling follow request #650

Closed polyamAdmin closed 1 month ago

polyamAdmin commented 1 month ago

Follow-up to #649

I still think having a different message in the confirmation modal is less confusing. A follow request is more of a "follow" than a follow.

The requested value needs to be passed down to the modal as trying to retrieve the value from account yields undefined.

polyamAdmin commented 1 month ago

The requested value needs to be passed down to the modal as trying to retrieve the value from account yields undefined.

The relationship could be fetched from state, but that seems a bit overkill since any component calling the modal already fetches the relationship to determine whether to show it or not, so it's more convenient to just pass the needed value down.

Ah, also apparently it's undefined only when the modal is called from the follow button component, since it fetches the relationship separately.